feat: improve rule configuration #314
Merged
+252
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
theseion
commented
Dec 22, 2024
theseion
commented
- Configure rules to update in a separate configuration file
- Use generic script to configure rules that doesn't rely on exact match of rule
- Log which rules are configured
- Log when a rule that should be configured wasn't found
theseion
force-pushed
the
improve-rule-configuration
branch
4 times, most recently
from
32ebed2 to
2f1b656
Compare
fzipi
previously approved these changes
Dec 23, 2024
theseion
force-pushed
the
improve-rule-configuration
branch
7 times, most recently
from
9a7e956 to
bb4f450
Compare
- Configure rules to update in a separate configuration file - Use generic script to configure rules that doesn't rely on exact match of rule - Log which rules are configured - Log when a rule that should be configured wasn't found
theseion
force-pushed
the
improve-rule-configuration
branch
9 times, most recently
from
a7ef97c to
8b1857a
Compare
theseion
force-pushed
the
improve-rule-configuration
branch
from
8b1857a to
9f08de4
Compare
|
@fzipi I've implemented a simple way to test the logic. That did uncover a few issues with the code I had written. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.